Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed typeguard dependency #81

Merged
merged 2 commits into from
May 26, 2023
Merged

Removed typeguard dependency #81

merged 2 commits into from
May 26, 2023

Conversation

agronholm
Copy link
Member

Fixes #80.

@coveralls
Copy link

coveralls commented May 26, 2023

Coverage Status

Coverage: 97.191% (-0.06%) from 97.247% when pulling 9a515b4 on remove-typeguard into 6e2b50e on master.

@jamescooke
Copy link

Just confirming this fix works using pip-tools and the default requirements file:

Using the current HEAD of the default branch fails as per #80 :

cat > requirements.in
git+https://github.com/asphalt-framework/asphalt
pandera
pip-compile
...
There are incompatible versions in the resolved dependencies:
  typeguard~=2.0 (from asphalt==4.11.1.post8->-r requirements.in (line 1))
  typeguard>=3.0.2 (from pandera==0.15.1->-r requirements.in (line 2))

Using this branch resolves the issue:

cat > requirements.in
git+https://github.com/asphalt-framework/asphalt.git@remove-typeguard
pandera
pip-compile

Success ✅

In the resulting requirements.txt file, typeguard is only required by pandera:

typeguard==4.0.0
    # via pandera

@agronholm agronholm merged commit 5576754 into master May 26, 2023
@agronholm agronholm deleted the remove-typeguard branch May 26, 2023 22:31
@agronholm
Copy link
Member Author

Alright, thanks for confirming. You can probably expect a release within the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirement on typeguard 2.* is too strict
3 participants